fix: remove elements appended to body in ngf-select on $destroy

[ciaran-phillips]

If the directive is added to something other than a file input, it adds
file input elements to the document body. Since these are outside of the
element the directive is applied to, they aren't automatically removed at
the end of its life.

The cleanup code for these elements already existed, but it was only being called
once when the directive was first applied, and wasn't doing anything. Now it
will be called on $destroy, and the file elements are correctly removed

[ciaran-phillips]

I will also update the README with examples of the git workflow, provided there are no major objections to it.

• At the moment master is tracking the upstream repo
• avr/develop is branched off the most recent release tag on master
• New fixes should be branched off the most recent release tag, and merged to avr-develop
• If we pull down a new release, we can rebase avr/develop on the new tag. The rebase will obviously hit conflicts in dist/ files, but that just requires running grunt to resolve

[gabskoro]

Sounds good!

Did you also pull these fixes?
danialfarid#1964
danialfarid#2031

[ciaran-phillips]

@gabskoro - no, I don't plan to pull in those fixes now. They can be added in a separate ticket, but it's also not very necessary. The clipboard data issue has been dealt with in another ticket this sprint, so that bug shouldn't really affect us anymore

CC @auchEnia

[gabskoro]

Still, it's just matter of time when we will again start using paste on some parts of our app and then will probably forget about this one. I think it doesn't hurt to include those fixes even we don't use parts that are "broken" and theoretically couldn't trigger them...

[ciaran-phillips]

Okay, I've created AV-7661 for that

[auchEnia]

looks good to me. now we just have to switch the dependency in the package.json 👍