Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STORE primitive is incorrect #14

Closed
aw opened this issue Jan 18, 2023 · 0 comments
Closed

STORE primitive is incorrect #14

aw opened this issue Jan 18, 2023 · 0 comments
Assignees
@aw
Labels
bug Something isn't working

Comments

@aw
Copy link
Owner

aw commented Jan 18, 2023

After some testing, it appears the STORE primitive is incorrect. Its definition:

# ! ( x addr -- )       Store x at addr

Is actually doing the opposite and trying to store addr at x.
@aw aw added the bug Something isn't working label Jan 18, 2023
@aw aw self-assigned this Jan 18, 2023
aw added a commit that referenced this issue Jan 18, 2023
@aw
Fix bug in STORE primitive. Fixes #14
510bb52
aw added a commit that referenced this issue Jan 19, 2023
@aw
Better error handling, bounds check, bug fixes. Fixes #7, #8, #13, #14
9c755ab
@aw aw closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aw aw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aw