Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds checks for stacks: overflow and underflow #7

Closed
aw opened this issue Jan 7, 2023 · 0 comments
Closed

Add bounds checks for stacks: overflow and underflow #7

aw opened this issue Jan 7, 2023 · 0 comments
Assignees
@aw
Labels
enhancement New feature or request

Comments

@aw
Copy link
Owner

aw commented Jan 7, 2023

It is currently possible to POP from the stacks even if nothing is there (underflow), and PUSH to the stacks if it's full (overflow). This applies to the DSP and RSP stack only, since TIB already has bounds checks.
@aw aw self-assigned this Jan 7, 2023
@aw aw added the enhancement New feature or request label Jan 7, 2023
aw added a commit that referenced this issue Jan 16, 2023
@aw
Add stack overflow and underflow bounds checks. Fixes #7
e798609
@aw aw closed this as completed in f4b83f1 Jan 16, 2023
aw added a commit that referenced this issue Jan 17, 2023
@aw
Revert "Add bounds check for stacks and user dictionary. Fixes #7 and f…
7fe14c7 
…ixes #8"

This reverts commit f4b83f1.
@aw aw reopened this Jan 17, 2023
aw added a commit that referenced this issue Jan 18, 2023
@aw
Add bounds check for stack underflow in data/return stacks. Fixes #7
35988b2
aw added a commit that referenced this issue Jan 18, 2023
@aw
Add bounds check for stack overflow in data/return stacks. Fixes #7
21b820c
@aw aw closed this as completed in 9c755ab Jan 19, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aw aw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aw