Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rsyslog section numbering to match CIS doc #123

Merged

Conversation

eastokes
Copy link
Contributor

I noticed this task was mis-numbered, checked against the CIS guidance pdf.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.166% when pulling 7109aae on eastokes:hotfix/fix-rsyslog-section-numbering into a58e5e6 on awailly:master.

@pchaigno
Copy link
Collaborator

I have 8.2.5 Configure rsyslog to Send Logs to a Remote Log Host (Scored) in my version (CIS Ubuntu 14.04 LTS Server Benchmark v1.0.0). Do you have a newer version?

@eastokes
Copy link
Contributor Author

@pchaigno Yes, 8.2.5 is that section, but this task block I've renumbered is for 8.2.2. 8.2.5 comes later in tasks/section_08_level1.yml and is numbered correctly.

8.2.2 specifies "Set the proper start conditions in /etc/init/rsyslog.conf: start on filesystem"

@pchaigno
Copy link
Collaborator

Oh, right! Then #L20 should be renamed to 8.2.2.1 Ensure the rsyslog Service is activated (check) (Scored) and #L31 to 8.2.2.2 Ensure the rsyslog Service is activated (Scored).

@eastokes
Copy link
Contributor Author

Good call, I'll update this PR

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.166% when pulling 727671f on eastokes:hotfix/fix-rsyslog-section-numbering into a58e5e6 on awailly:master.

@pchaigno
Copy link
Collaborator

Could you change the names too please? (They're also incorrect.)

@eastokes
Copy link
Contributor Author

My bad, should be good now

@pchaigno
Copy link
Collaborator

Could you also add (check) for 8.2.2.1 Ensure the rsyslog Service is activated (check) (Scored)? 😇

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.166% when pulling e8c79d6 on eastokes:hotfix/fix-rsyslog-section-numbering into a58e5e6 on awailly:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.166% when pulling 024842c on eastokes:hotfix/fix-rsyslog-section-numbering into a58e5e6 on awailly:master.

@pchaigno pchaigno merged commit 2cfa28f into awailly:master Dec 21, 2016
@pchaigno
Copy link
Collaborator

Thanks @eastokes!

@eastokes eastokes deleted the hotfix/fix-rsyslog-section-numbering branch January 27, 2017 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants