Fix if condition for upload-logs step #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a workflow I created to test this PR: https://github.com/lihop/cache-apt-pkgs-action/blob/test/.github/workflows/test.yml. In this run before the patch, it uploads logs for both steps despite only one having debugging enabled. |
Previously the if condition was always evaluating to a truthy string
(e.g. 'false == "true"' or 'true == "true"') as the string comparison
(`== 'true'`) was not inside the expression syntax (`${{ }}`) and thus
being treated as a string rather than being evaluated.
lihop
force-pushed
the
bugfix/#86/upload-logs-if-condition
branch
from
681aa77
to
0ef6349
Compare
ButterscotchV
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Approving because this matches the format used throughout GitHub docs:
if: ${{ vars.USE_VARIABLES == 'true' }}
https://docs.github.com/en/actions/learn-github-actions/variables
|
Thanks for the PR! I usually pull these into staging first but this is really straight forward. Going to roll this into a few more outstanding things before a new release. Let me know if you need it sooner. |
awalsh128
added a commit
that referenced
this pull request
Feb 4, 2023
* Fix if condition for upload-logs step (#87) Previously the if condition was always evaluating to a truthy string (e.g. 'false == "true"' or 'true == "true"') as the string comparison (`== 'true'`) was not inside the expression syntax (`${{ }}`) and thus being treated as a string rather than being evaluated. * Introduce a force update value for reloading cache #82 --------- Co-authored-by: Leroy Hopson <github@leroy.geek.nz>
awalsh128
added a commit
that referenced
this pull request
Feb 4, 2023
* Address block style package issue #84 #88 * Use cache key for upload artifact name #89. * Sync master back to dev. (#92) * Fix if condition for upload-logs step (#87) Previously the if condition was always evaluating to a truthy string (e.g. 'false == "true"' or 'true == "true"') as the string comparison (`== 'true'`) was not inside the expression syntax (`${{ }}`) and thus being treated as a string rather than being evaluated. * Introduce a force update value for reloading cache #82 --------- Co-authored-by: Leroy Hopson <github@leroy.geek.nz> --------- Co-authored-by: Leroy Hopson <github@leroy.geek.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the if condition was always evaluating to a truthy string (e.g. 'false == "true"' or 'true == "true"') as the string comparison (
== 'true') was not inside the expression syntax (${{ }}) and thus being treated as a string rather than being evaluated.