Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DOT-specific keywords #4

Closed
0xmichalis opened this issue Mar 19, 2015 · 5 comments
Closed

Expose DOT-specific keywords #4

0xmichalis opened this issue Mar 19, 2015 · 5 comments

Comments

@0xmichalis
Copy link

A user shouldn't manually construct DOT keywords before adding them in the attributes of a graph object. All the names mentioned in here should be exposed by this package.

@awalterschulze
Copy link
Owner

I agree, it would be safer to have all the attributes so stringly typed.

We could make type safe and constrained methods to build the map[string]string and not break the current API.

This is quite a long list of things to implement and, unfortunately, I am currently very busy, but I would be open to contribution.
I am very sorry and I hope that this is an acceptable answer?

@0xmichalis
Copy link
Author

Thanks for the answer! No worries, it's good that you agree about the issue. I might submit a PR if time permits it.:)

@awalterschulze
Copy link
Owner

I look forward to it :)

On 20 March 2015 at 12:30, Michail Kargakis notifications@github.com
wrote:

Thanks for the answer! No worries, it's good that you agree about the
issue. I might submit a PR if time permits it.:)


Reply to this email directly or view it on GitHub
#4 (comment)
.

@awalterschulze
Copy link
Owner

I have decided that we are going to make a breaking change to return some errors.
Or at least that is what this proposal is about
#23
Hopefully we can then fix this keyword problem as well.

@awalterschulze
Copy link
Owner

Merged pull request #25 with some attribute validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants