Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup file, refactor, make PSR-1 and PSR-2 compliant, make save compatible with Eloquent save #1

Merged
merged 5 commits into from
Apr 14, 2013

Conversation

whatyoubendoing
Copy link

No description provided.

@colbyr
Copy link

colbyr commented Apr 14, 2013

Looks awesome! 👍

Thanks a lot, I've been seriously low on time to clean this up.

colbyr added a commit that referenced this pull request Apr 14, 2013
Cleanup file, refactor, make PSR-1 and PSR-2 compliant, make save compatible with Eloquent save
@colbyr colbyr merged commit ca5d431 into awareness:master Apr 14, 2013
@whatyoubendoing
Copy link
Author

No problem @colbyr.

I was wanting to extend the testing, but having trouble with Validation::make, for testing this there needs to be some application environment setup in the test code which I was having trouble with. Do you have any idea how you would go about doing this, maybe it needs to be a integration test rather then a unit test.

Also man do you have any roadmap for Aware, any other features you would like to see added im quite keen to keep on contributing?

@colbyr
Copy link

colbyr commented Apr 22, 2013

Sorry @benhainez I lost control of my inbox last week!

I also kind of hit a wall setting up the testing environment. From what I've gathered since, laravel four has this concept of a "workbench". I haven't gotten into it much. You can read about it in the l4 docs.

Unfortunately, my work over the last couple months has taken me away from Laravel so I'm a bit out of touch as far as where aware should be going. Do you have any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants