Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #472

Merged
merged 6 commits into from Apr 12, 2013
Merged

Some fixes #472

merged 6 commits into from Apr 12, 2013

Conversation

Alexx999
Copy link
Contributor

@Alexx999 Alexx999 commented Feb 2, 2013

I wanted to split this into several requests, but GitHub added commits made after request here too, and I'm not that great git user, so here we go:

  1. fix unpaired mouse over/mouse out events
    This one is for situation when we send MouseOver event, then updateCollider fires and changes _previousCollidingObject, so we never actually get MouseOut event for that object, but we do get MouseOut for some other object which did not receive MouseOver yet.

  2. fix ObjectContainer3D bounds calculation
    Max* functions actually return Max for largest object in container, not container as a whole (which is probably not what was intended). This version accounts at least for child transition (works well for me)

3)added removeChildAt function
For me this function seems pretty useful for simple usage scenario such as "remove all children". Without such function it requires function chaining: removeChild(getChildAt(index)), which is additionally slower because of unneeded call to indexOf()

  1. OBJParser: do not create zero-length geometries
    Got that one on OBJ models that our artists created, so that was not intentionally malformed input

  2. check for zero-length data in CompactSubGeometry
    To help detect situations as with OBJParser, as it throws exception later anyway.

  3. normalize normals and tangents after transform
    Pretty much self-explaining - normals must be normalized

@rob-bateman rob-bateman merged commit 5cb0a5a into away3d:dev Apr 12, 2013
@rob-bateman
Copy link
Member

Hey Alex, thanks very much for your request, these updates have now been merged into the current dev branch

Please check the merge when you have a moment to make sure everything made it intact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants