Feature/utils #41
Merged
Feature/utils #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This might be usefull for people who want to check that See jesseduffield@e030e03 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This might be usefull for people who want to check that See jesseduffield@77d7618 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* Added a handler for tab * Added a handler for space * Added a handler for Insert * Added a handler for Ctrl+U * Added a handler for Ctrl+A * Added a handler for Ctrl+E * Defaults to EditWrite() See jesseduffield@77d7618 Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
* This might be useful for some projects See jesseduffield@bac774b Co-authored-by: Jesse Duffield <jessedduffield@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
golangcibot
reviewed
Sep 12, 2019
* Added Parse() to parse a string to a keybind * Added ParseAll() to parse multiple strings to keybinds * Added MustParse() to parse a string at all costs * Added MustParseAll() to parse multiple strings at all costs * Added an example Co-authored-by: Alex Goodman <wagoodman@gmail.com> Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
|
i'll merge after reviews |
skanehira
requested changes
Sep 13, 2019
mjarkk
reviewed
Sep 13, 2019
mjarkk
reviewed
Sep 13, 2019
mjarkk
reviewed
Sep 13, 2019
mjarkk
reviewed
Sep 13, 2019
mjarkk
reviewed
Sep 13, 2019
|
Also i was just thinking about something, |
|
@mjarkk I looked into doing that at some point but couldn't work out which key code to use, though I'm sure it's possible |
|
ping @jesseduffield @mjarkk @skanehira , I hope to get some feedback on the comments i made |
* Allows developers to add / remove keybindings from the blacklist * Added more precise errors * Made the simpleEditor simple again * Added some missing comments Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
|
@jesseduffield @mjarkk @skanehira all the comments have been implemented, lmk what you guys think |
mjarkk
approved these changes
Oct 12, 2019
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.