Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions from issues #1546

Merged
merged 8 commits into from
Oct 23, 2018
Merged

Additions from issues #1546

merged 8 commits into from
Oct 23, 2018

Conversation

Pe46dro
Copy link
Contributor

@Pe46dro Pe46dro commented Oct 21, 2018

This PR will complete the following issue

#986
#1286
#1237
#1356
#1375
#1478
#1477 - Only fixed name
#1479

#1299 - Already completed

To ensure your PR is dealt with swiftly please check the following:

  • Your submissions are formatted according to the following requirements:

- [Name](http://homepage/) - Short description, less than 250 characters. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`

Depends on proprietary services:

- [Name](http://homepage/) `⚠` - Short description, less than 250 characters. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`

Non-free software in non-free.md:

- [Name](http://homepage/) `⊘ Proprietary` - Short description, less than 250 characters. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `Language`

  • Your additions are ordered alphabetically.
  • Your additions are Free software, or if not they have been added to non-free and marked ⊘ Proprietary.
  • If your additions depend on proprietary services outside the user's control, they must be marked .
  • Your additions are not already listed at awesome-sysadmin (IT infrastructure management), staticgen.com or staticsitegenerators.net (static site generators).
  • Your additions have their License main server-side Language/platform/requirement listed.
  • Any licenses you have added are in our list of licenses.
  • You have searched the repository for any relevant issues or PRs, incluing closed ones.
  • If the main link of your addition points to the program's source code, there is no need to add a duplicate Source Code link. The Demo and Clients links are not mandatory.
  • Any category you are creating has the minimum requirement of 3 items. If not, your addition may be inserted into Misc/Other.
  • Any software project you are adding to the list is actively maintained.

@Kickball Kickball added the fix label Oct 22, 2018
Copy link
Collaborator

@Kickball Kickball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for working through all of these issues @Pe46dro!

@Kickball
Copy link
Collaborator

The only problem might be with the authors document, you may need to run make contrib instead to update all contributors.

@Pe46dro
Copy link
Contributor Author

Pe46dro commented Oct 23, 2018

Fixed

Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Pe46dro
Copy link
Contributor Author

Pe46dro commented Oct 23, 2018

@Kickball FYI
I made a pull request on the helper to automatically capitalize the first letter in description (n8225/n8225.github.io#14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants