Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoGuess to Games #2856

Closed
wants to merge 2 commits into from

Conversation

BilelJegham
Copy link

@BilelJegham BilelJegham commented Jan 29, 2022

Thank you for taking the time to work on a PR for Awesome-Selfhosted!

To ensure your PR is dealt with swiftly please check the following:

  • Submit one item per pull request. This eases reviewing and speeds up inclusion.
  • Format your submission as follows, where Demo and Clients are optional.
    Do not add a duplicate Source code link if it is the same as the main link.
    Keep the short description under 250 characters and use sentence case
    for it, even if the project's webpage or readme uses another capitalisation
    such as title case, all caps, small caps or all lowercase.
    Demo links should only be used for interactive demos, i.e. not video demonstrations.
    - [Name](http://homepage/) - Short description, under 250 characters, sentence case. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`
  • Additions that depend on proprietary services outside the user's control must be marked .
    - [Name](http://homepage/) `⚠` - Short description, under 250 characters, sentence case. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `License` `Language`
  • Additions that are not Free software
    must be added to non-free.md and marked ⊘ Proprietary:
    - [Name](http://homepage/) `⊘ Proprietary` - Short description, under 250 characters, sentence case. ([Demo](http://url.to/demo), [Source Code](http://url.of/source/code), [Clients](https://url.to/list/of/related/clients-or-apps)) `Language`
  • Additions are inserted preserving alphabetical order.
  • Additions are not already listed at any of awesome-sysadmin, awesome-analytics, staticgen.com, staticsitegenerators.net.
  • The Language tag is the main server-side requirement for the software. Don't include frameworks or specific dialects.
  • Any license you add is in our list of licenses.
  • You have searched the repository for any relevant issues or PRs, including closed ones.
  • Any category you are creating has the minimum requirement of 3 items.
    If not, your addition may be inserted into Misc/Other.
  • Any software project you are adding to the list is actively maintained.
  • The pull request title is informative, unlike "Update README.md".
    Suggested titles: "Add aaa to bbb" for adding software aaa to section bbb,
    "Remove aaa from bbb" for removing, "Fix license for aaa", etc.

Copy link

@Armanfaryad Armanfaryad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A

@nodiscc
Copy link
Member

nodiscc commented Apr 23, 2022

Related to #2759 (Earthwalker) (100% dependent/is a wrapper around a non-free service). Must decide if these kind of projects should be added to the list (this one is missing the symbol, at the very least)

<iframe src="https://maps.google.com" title="my self-hosted application!"></iframe>

@BilelJegham
Copy link
Author

BilelJegham commented Apr 29, 2022

Thanks for your review @nodiscc
added

@nodiscc
Copy link
Member

nodiscc commented Aug 10, 2022

After thinking about it for a while, I don't think we should add it, see comments at #2759.

But I opened an issue at osmlab/awesome-openstreetmap#113 to get it added there instead, and awesome-openstreetmap is linked from https://github.com/awesome-selfhosted/awesome-selfhosted#maps-and-global-positioning-system-gps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants