Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme/titlebar: missing icon for minimize button #387

Closed
blueyed opened this issue Aug 2, 2015 · 2 comments · Fixed by #995
Closed

theme/titlebar: missing icon for minimize button #387

blueyed opened this issue Aug 2, 2015 · 2 comments · Fixed by #995
Milestone
v4.0

Comments

@blueyed
Copy link
Member

blueyed commented Aug 2, 2015

Via #369 (comment), from @actionless:

also it seems like we are missing an icon for minimize: http://awesome.naquadah.org/doc/api/modules/awful.titlebar.html#titlebar.widget.minimizebutton
@blueyed blueyed changed the title titlebar: missing icon for minimize button theme/titlebar: missing icon for minimize button Aug 2, 2015
@actionless
Copy link
Member

after you'll merge that PR i can add it

@actionless actionless mentioned this issue Aug 23, 2015
Closed
@sixshotx
Copy link

sixshotx commented Feb 3, 2016

The latest titlebar.lua in lib/awful directory might still have the problem.
local widget = titlebar.widget.button(c, "minimize", function() return c.minimized end, function(c) c.minimized = not c.minimized end)

parameter "c" is missing in the first function().

@psychon psychon added this to the v3.6 milestone Jul 4, 2016
psychon added a commit to psychon/awesome that referenced this issue Jul 9, 2016
@psychon
Fix the titlebar minimize button
5443993 
Commit 0318c61 added an image for the minimize button which was
missing before. However, only the default theme and xresources where fixed to
contain the path to the image.

This commit adds the path to all themes.

Also, minimized clients aren't visible, just as closed (=killed) clients aren't
visible. Thus, we don't need an "active" version of this image.

This commit makes us handle the image for the minimize button just like we
handle the close button: There is no difference between "active" and "inactive"
and the file path in the theme doesn't get any path suffix.

Fixes: awesomeWM#387
Signed-off-by: Uli Schlachter <psychon@znc.in>
@psychon psychon mentioned this issue Jul 9, 2016
Merged
psychon added a commit to psychon/awesome that referenced this issue Jul 9, 2016
@psychon
Fix the titlebar minimize button
bc2eed0 
Commit 0318c61 added an image for the minimize button which was
missing before. However, only the default theme and xresources where fixed to
contain the path to the image.

This commit adds the path to all themes.

Also, minimized clients aren't visible, just as closed (=killed) clients aren't
visible. Thus, we don't need an "active" version of this image.

This commit makes us handle the image for the minimize button just like we
handle the close button: There is no difference between "active" and "inactive"
and the file path in the theme doesn't get any path suffix.

Fixes: awesomeWM#387
Signed-off-by: Uli Schlachter <psychon@znc.in>
psychon added a commit to psychon/awesome that referenced this issue Jul 9, 2016
@psychon
Fix the titlebar minimize button
e798ed8 
Commit 0318c61 added an image for the minimize button which was
missing before. However, only the default theme and xresources where fixed to
contain the path to the image.

This commit adds the path to all themes.

Also, minimized clients aren't visible, just as closed (=killed) clients aren't
visible. Thus, we don't need an "active" version of this image.

This commit makes us handle the image for the minimize button just like we
handle the close button: There is no difference between "active" and "inactive"
and the file path in the theme doesn't get any path suffix.

Fixes: awesomeWM#387
Signed-off-by: Uli Schlachter <psychon@znc.in>
blueyed pushed a commit that referenced this issue Jul 9, 2016
@psychon @blueyed
Fix the titlebar minimize button (#995)
1a5680e 
Commit 0318c61 added an image for the minimize button which was
missing before. However, only the default theme and xresources where fixed to
contain the path to the image.

This commit adds the path to all themes.

Also, minimized clients aren't visible, just as closed (=killed) clients aren't
visible. Thus, we don't need an "active" version of this image.

This commit makes us handle the image for the minimize button just like we
handle the close button: There is no difference between "active" and "inactive"
and the file path in the theme doesn't get any path suffix.

Fixes: #387
Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
4 participants
@blueyed @psychon @actionless @sixshotx