Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gravity-related changes #2363

Merged
merged 3 commits into from Oct 7, 2018
Merged

Commits on Aug 20, 2018

  1. Refactor event_handle_configurerequest

    Before this commit, the code in here first handled clients changing its
    x/y position and afterwards it handled resizes. This meant that the
    special case of "client resizes without moving itself so we need to
    apply gravity" had to have special checks on whether the client moved
    itself or not.
    
    Change the code so that resizes are handled first and moves later. This
    naturally handles the problem: If the client resizes and moves itself,
    the move done for the resize is later overwritten when the move is
    handled.
    
    No functional changes are intended.
    
    Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
    psychon committed Aug 20, 2018
    Copy the full SHA
    2ebd120 View commit details
    Browse the repository at this point in the history
  2. Handle border width changes in ConfigureRequests early

    The function window_set_border_width() causes its own gravity handling.
    Thus, to make sure that this gravity handling does not interfere with
    what the code in here does later, we just apply changes to the border
    width first, and then do everything else.
    
    Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
    psychon committed Aug 20, 2018
    Copy the full SHA
    62d2795 View commit details
    Browse the repository at this point in the history
  3. event_handle_configurerequest: Add missing test

    c->size_hints.win_gravity only contains something valid if the
    XCB_ICCCM_SIZE_HINT_P_WIN_GRAVITY bit is set in the flags. Most likely
    this wasn't noticed before, because most code just happens to
    zero-initialize this field and gravity 0 is NorthWest, which does not do
    anything.
    
    Signed-off-by: Uli Schlachter <uli.schlachter@informatik.uni-oldenburg.de>
    psychon committed Aug 20, 2018
    Copy the full SHA
    a54fea4 View commit details
    Browse the repository at this point in the history