awful.widget.common: Use a template for the default template #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the default template hardcoded as code, this turns the template into a descriptive version. This makes it easier to come up with own templates: Just copy the default template and make a slight change to it. No functional changes are intended, but I cannot rule out that I did no mistakes. Signed-off-by: Uli Schlachter <psychon@znc.in>
Codecov Report
@@ Coverage Diff @@
## master #2735 +/- ##
==========================================
- Coverage 86.25% 86.23% -0.03%
==========================================
Files 529 529
Lines 36447 36450 +3
==========================================
- Hits 31439 31434 -5
- Misses 5008 5016 +8
|
Elv13
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
@Elv13 Can you check if I converted this correctly? Are there any downsides to this conversion that I do not know about?
The conversion looks good. The downside is mostly that #2726 is not being reviewed... Anyhow I would not have the time to fix all the review suggestions. #2726 uses a template for the tasklist and improve the template system to make the declaration more compact. #2508 improve all widgets to allow templates to be used directly everywhere. #2244 allows "creation time logic" to be part of the template (rather than lua expressions that are executed during the initial evaluation).
actionless
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having the default template hardcoded as code, this turns the
template into a descriptive version. This makes it easier to come up
with own templates: Just copy the default template and make a slight
change to it.
No functional changes are intended, but I cannot rule out that I did no
mistakes.
Signed-off-by: Uli Schlachter psychon@znc.in
@Elv13 Can you check if I converted this correctly? Are there any downsides to this conversion that I do not know about?