Fix _NET_CURRENT_DESKTOP ClientMessage handling #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <psychon@znc.in>
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
==========================================
+ Coverage 88.21% 89.00% +0.78%
==========================================
Files 662 704 +42
Lines 44962 51089 +6127
==========================================
+ Hits 39662 45470 +5808
- Misses 5300 5619 +319
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Aire-One
approved these changes
Dec 30, 2020
actionless
approved these changes
Dec 30, 2020
This was referenced Jan 16, 2021
This was
linked to
issues
Jan 16, 2021
|
Do we need to close/reopen this to make codecov run again? It seems it just randomly crashed... |
Elv13
approved these changes
Apr 25, 2021
actionless
pushed a commit
to actionless/awesome
that referenced
this pull request
Apr 26, 2021
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <psychon@znc.in>
man9ourah
pushed a commit
to man9ourah/awesome
that referenced
this pull request
Nov 25, 2021
This was broken in commit c5202a4 by adding an extra string to the Lua stack. Hence, the offset -1 now referred to the string and not the tag. Fixes: awesomeWM#3236 Signed-off-by: Uli Schlachter <psychon@znc.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken in commit c5202a4 by adding an extra string
to the Lua stack. Hence, the offset -1 now referred to the string and
not the tag.
Fixes: #3236
Signed-off-by: Uli Schlachter psychon@znc.in