Add a scroll smooth step function #3909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actionless
previously approved these changes
Apr 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3909 +/- ##
==========================================
- Coverage 91.27% 91.26% -0.01%
==========================================
Files 935 935
Lines 60129 60131 +2
==========================================
- Hits 54880 54877 -3
- Misses 5249 5254 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sclu1034
reviewed
Apr 8, 2024
lib/wibox/container/scroll.lua
Outdated
| local state = ((elapsed * speed) % (size)) / size | ||
| -- The cosine function is scaled to map [0,1] to [0,2π] then it’s output is | ||
| -- scaled from [1 -- -1 -- 1] to [0 -- 1 -- 0] | ||
| return (size - visible_size) * (0.5 - 0.5*math.cos(state*6.2832)) |
There was a problem hiding this comment.
2 * math.pi would be preferable to some magic number literal.
There was a problem hiding this comment.
It’s clearly more readable with it, I must admit I did not check if it existed in lua.
Aire-One
approved these changes
Apr 8, 2024
sclu1034
approved these changes
Apr 9, 2024
actionless
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple smooth step function for scroll based on a cosine.