Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SendWP promo #8498

Closed
pderksen opened this issue Mar 19, 2021 · 2 comments · Fixed by #8504
Closed

Update SendWP promo #8498

pderksen opened this issue Mar 19, 2021 · 2 comments · Fixed by #8504
Assignees
@cklosowski
Milestone
2.10.2

Comments

@pderksen
Copy link
Contributor

Enhancement Request

Explain your enhancement (please be detailed)

In Settings > Email > General, we need to:

  • Move the SendWP promo to 2nd on the list (between Email Configuration and soon Recapture).
  • Update copy in subheading, label, main text and CTA button.
  • Display a notice in place of button after SendWP plugin is activated.

This needs to go in the next 2.10.x release of EDD if at all possible.

Related issues that probably make sense to do at the same time:

Subheading:
SendWP <-- remove "Settings"

Label:
Deliverability settings

Text:
We recommend SendWP to ensure quick and reliable delivery of all emails sent from your store, such as purchase receipts, subscription renewal reminders, password resets, and more. Learn more here (free trial available).

[Connect with SendWP] <-- add "with"

The CTA button background already installs the SendWP plugin and redirects to https://sendwp.com/_/signup/register (no change).

To add: Once the SendWP plugin is activated, instead of a CTA button, show a “notice-success” styled message:

SendWP plugin activated. Access your SendWP account.

  • The external links (i.e. "Learn more here" and "Access your SendWP account.") should open in a new tab.

This mimics the way we replace the connect button with a notice for the Stripe connection workflow.
image

Final order on email settings page should be:

  • Email Configuration
  • SendWP
  • Recapture

Current page layout:
image
This was referenced Mar 19, 2021
Closed
Closed
@cklosowski cklosowski added this to the 2.10.2 milestone Mar 19, 2021
@cklosowski cklosowski self-assigned this Mar 19, 2021
@cklosowski
Copy link
Contributor

@pderksen Here are the changes.

Screenshot_2021-03-22 Easy Digital Downloads Settings ‹ DEV EDD — WordPress(2)
Screenshot_2021-03-22 Easy Digital Downloads Settings ‹ DEV EDD — WordPress(1)

cklosowski added a commit that referenced this issue Mar 22, 2021
@cklosowski
Updates to the SendWP setting information #8497 #8498
562129c
@cklosowski
Copy link
Contributor

I'm working on this inside of issue/8497

@cklosowski cklosowski mentioned this issue Mar 22, 2021
Merged
@cklosowski cklosowski linked a pull request Mar 23, 2021 that will close this issue
Issue/8497 #8504
Merged
cklosowski added a commit that referenced this issue Mar 30, 2021
@cklosowski @ashleyfae
Issue/8497 (#8504)
a65b170 
* Updates to the SendWP setting information #8497 #8498

* Remove Jilt callbacks #8497 #8290

* Properly deprecate Jilt callbacks and remove JS functions #8497 #8290

* Add Recapture settings section, as well as all the states the integration can be in #8497

* Replace accidently removed SendWP client registration #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/emails/functions.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/emails/functions.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Fixing spelilng of connection_complete #8497

* Require the 'install_plugins' cap to see the connect with Recapture button #8497

* Remove 'here' reference in complete connection for recapture #8497

* Deprecate more Jilt functions, remove CSS references, and swtich the abandoned payment notice #8497

* Remove Advanded Emails header #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Clean up double indents after copying functions to deprected functions file #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Fix double indenting #8497

* Fix double indenting #8497

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>
@cklosowski cklosowski mentioned this issue Mar 31, 2021
Merged
cklosowski added a commit that referenced this issue Apr 5, 2021
@cklosowski @ashleyfae @robincornett
Release/2.10.2 (#8534)
f97f4f6 
* Move Stripe to the frist payment gateway in the Available Gateway Settings when it is found #8499 (#8501)

* Add ilnks to Termageddon on privacy policy and terms of agreement settings #8506 (#8507)

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Remove GLOB_BRACE flag #8519 (#8520)

* Add edd_honeypot to the registration form validation. (#8510)

* Added honeypot validation during user registration (#6116)

Whilst the `edd_honeypot` field is present within the `[edd_register]`
registration form there was no validation of this field

Co-authored-by: Mike Howard <mike@mikeandniki.co.uk>

* Add honeypot field to validation #6115

* Update includes/login-register.php

Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com>

Co-authored-by: Mike Howard <mike@mikesplugins.co.uk>
Co-authored-by: Mike Howard <mike@mikeandniki.co.uk>
Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com>

* Issue/8497 (#8504)

* Updates to the SendWP setting information #8497 #8498

* Remove Jilt callbacks #8497 #8290

* Properly deprecate Jilt callbacks and remove JS functions #8497 #8290

* Add Recapture settings section, as well as all the states the integration can be in #8497

* Replace accidently removed SendWP client registration #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/emails/functions.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/emails/functions.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Fixing spelilng of connection_complete #8497

* Require the 'install_plugins' cap to see the connect with Recapture button #8497

* Remove 'here' reference in complete connection for recapture #8497

* Deprecate more Jilt functions, remove CSS references, and swtich the abandoned payment notice #8497

* Remove Advanded Emails header #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Clean up double indents after copying functions to deprected functions file #8497

* Update includes/admin/settings/register-settings.php

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Fix double indenting #8497

* Fix double indenting #8497

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>

* Add stripe revision during build #8529 (#8529)

* Changelog for 2.10.2

* Rebuild with updated readme stable version

* Use default branch for Stripe update

* Updating Stripe hash

Co-authored-by: Ashley Gibson <ashley@nosegraze.com>
Co-authored-by: Mike Howard <mike@mikesplugins.co.uk>
Co-authored-by: Mike Howard <mike@mikeandniki.co.uk>
Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cklosowski cklosowski

Labels
None yet
Projects
None yet
Milestone
2.10.2
Development

Successfully merging a pull request may close this issue.

Issue/8497 awesomemotive/easy-digital-downloads
2 participants
@pderksen @cklosowski