-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honeypot validation during registration. Fixes #6115 #6116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst the `edd_honeypot` field is present within the `[edd_register]` registration form there was no validation of this field
I'm going to merge this into an issue branch and rework it a little bit. By doing this you'll still retain the original props @mikeyhoward1977 |
cklosowski
added a commit
that referenced
this pull request
Mar 29, 2021
* Added honeypot validation during user registration (#6116) Whilst the `edd_honeypot` field is present within the `[edd_register]` registration form there was no validation of this field Co-authored-by: Mike Howard <mike@mikeandniki.co.uk> * Add honeypot field to validation #6115 * Update includes/login-register.php Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com> Co-authored-by: Mike Howard <mike@mikesplugins.co.uk> Co-authored-by: Mike Howard <mike@mikeandniki.co.uk> Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com>
cklosowski
added a commit
that referenced
this pull request
Apr 5, 2021
* Move Stripe to the frist payment gateway in the Available Gateway Settings when it is found #8499 (#8501) * Add ilnks to Termageddon on privacy policy and terms of agreement settings #8506 (#8507) Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Remove GLOB_BRACE flag #8519 (#8520) * Add edd_honeypot to the registration form validation. (#8510) * Added honeypot validation during user registration (#6116) Whilst the `edd_honeypot` field is present within the `[edd_register]` registration form there was no validation of this field Co-authored-by: Mike Howard <mike@mikeandniki.co.uk> * Add honeypot field to validation #6115 * Update includes/login-register.php Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com> Co-authored-by: Mike Howard <mike@mikesplugins.co.uk> Co-authored-by: Mike Howard <mike@mikeandniki.co.uk> Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com> * Issue/8497 (#8504) * Updates to the SendWP setting information #8497 #8498 * Remove Jilt callbacks #8497 #8290 * Properly deprecate Jilt callbacks and remove JS functions #8497 #8290 * Add Recapture settings section, as well as all the states the integration can be in #8497 * Replace accidently removed SendWP client registration #8497 * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/emails/functions.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/emails/functions.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Fixing spelilng of connection_complete #8497 * Require the 'install_plugins' cap to see the connect with Recapture button #8497 * Remove 'here' reference in complete connection for recapture #8497 * Deprecate more Jilt functions, remove CSS references, and swtich the abandoned payment notice #8497 * Remove Advanded Emails header #8497 * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Clean up double indents after copying functions to deprected functions file #8497 * Update includes/admin/settings/register-settings.php Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Fix double indenting #8497 * Fix double indenting #8497 Co-authored-by: Ashley Gibson <ashley@nosegraze.com> * Add stripe revision during build #8529 (#8529) * Changelog for 2.10.2 * Rebuild with updated readme stable version * Use default branch for Stripe update * Updating Stripe hash Co-authored-by: Ashley Gibson <ashley@nosegraze.com> Co-authored-by: Mike Howard <mike@mikesplugins.co.uk> Co-authored-by: Mike Howard <mike@mikeandniki.co.uk> Co-authored-by: Robin Cornett <robincornett@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The honeypot field generated via
[edd_register]
is never validated.Added
edd_do_honeypot_check()
function to check for value within this field.Added call to
edd_do_honeypot_check()
during registration process