-
Notifications
You must be signed in to change notification settings - Fork 33
Add search results pagination #5
Comments
I believe there should be code for this in SimpleMap v2.5. |
I also added new style classes to allow users more control over the customization.
Thinking about it now, may need to cancel PR #229 to add additions to Light & Dark CSS files. Even if there is no styling, would it be best to make those additions to .css files? |
@EkoJR We should use the standard classes for CSS which can be found here - https://codex.wordpress.org/Pagination. You should be able to test with Twenty Sixteen or Twenty Seventeen themes and the styling should be the same as the rest of the pagination in the theme. I tested PR #231 but the Next and Prev links didn't do anything and there were no JS errors in the browser console. |
@EkoJR I have tested this and found that when you click on Prev or Next nothing happens For example, if I have 5 locations and I set Number of Results to Display to 10 then there should be no pagination because there's only 5 locations which is less than the 10 set in Number of Results to Display. |
@EkoJR I tested this and the pagination works fine now. However, the search no longer outputs only matching locations, instead it seems to output locations outside of the search criteria. For example, if I have 6 locations within 10 miles of ZIP code 27540 and I search based on that criteria, the paginated search results actually outputs 10 locations which include locations in other States and other countries. |
This is tested and is working fine. This is ready for a code review. The branch with the latest commits is https://github.com/EkoJr/simplemap/tree/issue-5 |
Add search results pagination
The text was updated successfully, but these errors were encountered: