in admin, render price as string to prevent bogus farmatting

awesto · Mar 18, 2018 · 2c5435c · 2c5435c
1 parent 6b62f38
commit 2c5435c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/example/myshop/admin/i18n_polymorphic.py b/example/myshop/admin/i18n_polymorphic.py
@@ -116,5 +116,5 @@ class ProductAdmin(PolymorphicSortableAdminMixin, PolymorphicParentModelAdmin):
     list_max_show_all = 1000
 
     def get_price(self, obj):
-        return obj.get_real_instance().get_price(None)
+        return str(obj.get_real_instance().get_price(None))
     get_price.short_description = _("Price starting at")
diff --git a/example/myshop/admin/polymorphic_.py b/example/myshop/admin/polymorphic_.py
@@ -86,5 +86,5 @@ class ProductAdmin(PolymorphicSortableAdminMixin, PolymorphicParentModelAdmin):
     list_max_show_all = 1000
 
     def get_price(self, obj):
-        return obj.get_real_instance().get_price(None)
+        return str(obj.get_real_instance().get_price(None))
     get_price.short_description = _("Price starting at")
diff --git a/shop/serializers/bases.py b/shop/serializers/bases.py
@@ -47,6 +47,7 @@ def __init__(self, *args, **kwargs):
 
     def get_price(self, product):
         price = product.get_price(self.context['request'])
+        # TODO: check if this can be simplified using str(product.get_price(...))
         if six.PY2:
             return u'{:f}'.format(price)
         return '{:f}'.format(price)