Public ECR

[RickyCook]

When giving a public ECR like this (to push an image):

      - name: Login to Amazon ECR
        id: login-ecr
        uses: aws-actions/amazon-ecr-login@v1
        with:
          registries: public.ecr.aws/deadbeef

The step fails and gives the error:

Member must satisfy regular expression pattern: [0-9]{12}

[danielpacak]

The registries input param seems to be very confusing. Reading the code https://github.com/aws-actions/amazon-ecr-login/blob/master/action.yml#L8 it expects a comma-separated list of Account IDs. This would justify such regexp error.

[danielpacak]

IIUC there's code change required to use aws.ECRPUBLIC service to get login credentials. Anyway, I'd love to see the confirmation from maintainers how we can publish to ECR Gallery with this awesome action!

[Malax]

In case anyone has the same problem and is looking for a solution: https://github.com/docker/login-action can be used to login into public ECR.

[fardin01]

In case anyone has the same problem and is looking for a solution: https://github.com/docker/login-action can be used to login into public ECR.

This action does not support IAM roles out of the box, does it?

[roimor]

@danielpacak @RickyCook @allisaurus
do you know if this was implemented ?

[heanzyzabala]

Any updates on this pls?

[marcelloromani]

This requires a code change, this actions at the moment only supports Private ECRs

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECRPUBLIC.html

I believe the registries parameters implicitly refers to the default (i.e. private) ECR of the specified AWS accounts.

[jpdsteno]

Would love for this to be implemented soon. Having to use two discrete actions to login to each ECR registry (public and private) is not great.

[jlbutler]

Hi everyone! This has been here a while, we're going to get some things done around this very soon.

Would you prefer that support for ECR Public is added to this action, or should we create a second action for ECR Public login and keep this one focused on ECR?

Thanks!

[gmeligio]

It would be great if this action supports both private and public repositories. The name is intuitive, and developers have already tried to use it for both cases. One similar action that supports different types of repositories is docker/build-push-action and it's a great experience. Thank you for your work!

[berviantoleo]

Hi everyone! This has been here a while, we're going to get some things done around this very soon.

Would you prefer that support for ECR Public is added to this action, or should we create a second action for ECR Public login and keep this one focused on ECR?

Thanks!

I prefer to add ECR Public in this action.