Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add service example to README #330

Merged
merged 1 commit into from Oct 26, 2022
Merged

docs: add service example to README #330

merged 1 commit into from Oct 26, 2022

Conversation

arjraman
Copy link
Contributor

@arjraman arjraman commented Aug 5, 2022

Issue #, if available:
#309 #247

Description of changes:
Added an example on how to use a private image as a service using the Docker credentials outputted by this action. Thank you to @JannikArndt for suggesting this change in #247!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@arjraman arjraman requested a review from monirul August 5, 2022 19:38
@aelgn
Copy link

aelgn commented Oct 16, 2022

@arjraman thank you for this. Great example for using gh actions services with ecr login. Just a pity it has not been merged - it would have saved me a lot of time :)

@monirul maybe merge this?

@arjraman arjraman merged commit 3e4df45 into main Oct 26, 2022
@arjraman arjraman deleted the docs branch October 26, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants