Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use node16 #354

Merged

Conversation

gotoeveryone
Copy link
Contributor

Issue #329, if available:

Description of changes:
This PR updates the using runtime to node16, rather than node12.
ref: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gotoeveryone gotoeveryone changed the title Chore/update runtime to node16 upgrade to use nodejs v16 Oct 11, 2022
@gotoeveryone gotoeveryone changed the title upgrade to use nodejs v16 Upgrade to use nodejs v16 Oct 11, 2022
@gotoeveryone gotoeveryone changed the title Upgrade to use nodejs v16 Upgrade to use node16 Oct 11, 2022
@aewshyae
Copy link

We're fully relying on this github action.
I hope this will be merged and released as soon as possible.
Thanks

@snyderpa-owl
Copy link

Message from github:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: aws-actions/configure-aws-credentials, aws-actions/amazon-ecr-login, slackapi/slack-github-action, aws-actions/amazon-ecr-login, aws-actions/configure-aws-credentials

@renperez-cpi
Copy link

any update on this? hoping to get this update soon

@gabrielmocanu
Copy link

It would be great to have this integrated and released.

1 similar comment
@shameemshah
Copy link

It would be great to have this integrated and released.

@aewshyae
Copy link

It'd be appreciated it's merged and released, but it also good if got released v1-node16 as aws-actions/configure-aws-credentials did. aws-actions/configure-aws-credentials#489 (comment)

@arjraman arjraman merged commit e70c985 into aws-actions:main Oct 18, 2022
@arjraman
Copy link
Contributor

Thank you to @gotoeveryone for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants