Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dockerLabels #274

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

johnseekins-pathccm
Copy link
Contributor

Issue #, if available: #272

Description of changes:

Add support for dockerLabels in task rendering. Basically updating #138

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: John Seekins <john.seekins@pathccm.com>
@johnseekins-pathccm
Copy link
Contributor Author

@sapekshm @iamhopaul123 I see you've recently worked on PRs in this repo. Any chance we could get this change merged? And maybe even a new release cut with this change?

@iamhopaul123
Copy link

Hello @johnseekins-pathccm the PR looks good to me. Can you fix failed checks before merging?

@johnseekins-pathccm johnseekins-pathccm changed the title support dockerLabels feature: support dockerLabels Oct 13, 2023
Signed-off-by: John Seekins <john.seekins@pathccm.com>
@johnseekins-pathccm
Copy link
Contributor Author

I can't run workflows, but tests are passing locally now. @iamhopaul123 , I think this is ready?

@iamhopaul123
Copy link

hello @johnseekins-pathccm looks like the tests are green now. Can you follow the https://conventionalcomments.org/ and fix the title and commit?

@KollaAdithya
Copy link
Contributor

@johnseekins-pathccm ! Can you change your title to feat: support dockerLabels

@johnseekins-pathccm johnseekins-pathccm changed the title feature: support dockerLabels feat: support dockerLabels Oct 16, 2023
@johnseekins-pathccm
Copy link
Contributor Author

It's pretty clear that whatever I did didn't follow semantic commits and I don't entirely understand how to fix it. Y'all are welcome to just take the code in a new PR, or if someone wants to tell me exactly how to format the PR to make this work, I'd love some advice.

@tristanhill-iris
Copy link

It's pretty clear that whatever I did didn't follow semantic commits and I don't entirely understand how to fix it. Y'all are welcome to just take the code in a new PR, or if someone wants to tell me exactly how to format the PR to make this work, I'd love some advice.

@johnseekins-pathccm I don't think rerunning the workflow actually refreshes the values passed into it via the context.payload.pull_request (https://github.com/aws-actions/amazon-ecs-render-task-definition/actions/runs/6509556132/job/17971730910?pr=274#step:2:5), so it's still validating against the old PR title. You could try pushing a new commit (or amend the last one) with no changes to re-trigger the check?

@mergify mergify bot merged commit b9718e5 into aws-actions:master Oct 23, 2023
6 checks passed
@johnseekins-pathccm johnseekins-pathccm deleted the docker-labels branch May 22, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants