-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Rate exceed" triggering for frequent builds #28
Comments
Looking at this, Keeping things simple, |
@seebees that sounds great. I think another solid idea would be to simply wrap the call in a try/catch and then retry, rather than have the entire action fail because one api call was rate-limited |
Just sticking in a try/catch is simple, but scary. I'll throw some comments on the PR, |
Hi there,
My company uses a monorepo to build/deploy multiple projects at once. As such, we run 10+ checks using this action simultaneously, and if there are multiple PRs building at one time, we often seen failures along the lines of:
My suspicion is that this is actually the AWS api rate-limiting us on the backend as it makes repeated, simultaneous API calls from the same access key. This issue could probably be solved by either increasing the sleep time during
waitForBuildEndTime
or simply adding a try/catch block to avoid the process dying if the api call returns a rate limit error.The text was updated successfully, but these errors were encountered: