Issue #28: Increase sleep timeout to prevent api rate limiting #29
Conversation
|
Let's take advantage to the fact that we pass this value.
|
|
@seebees Made a few updates. The basic idea is: make the API call, check if we errored, and if we did, check that it's a rate limiting error. If so, sleep for a bit and try again (after extending the sleep timer). If not, throw an error (because it's a genuine error from the AWS API and as such, the job should fail). |
|
@seebees added tests to check for rate limiting retry logic and also to make sure it properly dies if it gets a different error from the AWS API |
|
|
||
| const sdk = help( | ||
| () => { | ||
| //similar to the ret function in the helper, allows me to throw an error in a function or return a more standard reply |
There was a problem hiding this comment.
Take a look at: https://sembr.org/
You might like it.
It makes the diff of comments much nicer
and easier to read in diff tools.
test/code-build-test.js
Outdated
| @@ -318,6 +318,104 @@ describe("waitForBuildEndTime", () => { | |||
| }); | |||
| expect(test).to.equal(buildReplies.pop().builds[0]); | |||
| }); | |||
|
|
|||
| it("waits after being rate limited and tries again", async function() { | |||
| this.timeout(45000); | |||
There was a problem hiding this comment.
see below, this can be dropped for both tests :)
| ]; | ||
|
|
||
| const sdk = help( | ||
| () => { |
There was a problem hiding this comment.
I'm going to say leave it now,
but maybe this functionality should be pulled into the root help function?
Issue #, if available: #28
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.