runtime: upgrade to use nodejs v16

[chenrui333]

Description

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

Checklist

• Run npm run all
• Update tests (if necessary)
• PR title follows Conventional Commits style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.

[chenrui333]

Should be a major version bump per the PR merge.

[hoffa]

Thanks for working on this!

Should be a major version bump per the PR merge.

I assume you're referring to the actions used in the workflows and not setup-sam itself?

[chenrui333]

Thanks for working on this!

Should be a major version bump per the PR merge.

I assume you're referring to the actions used in the workflows and not setup-sam itself?

almost forgot the node 16 lambda issue 🤦 I am still watching it though.

Yeah, you are totally correct, just the workflow runtime, not the lambda runtime.

[chenrui333]

Side question, when is node 16 going to be rolled out for AWS lambda. :)

[hoffa]

Merged; thanks for the contribution!

Side question, when is node 16 going to be rolled out for AWS lambda. :)

You'll have to keep an eye out on the issue above I'm afraid.

[hoffa]

I'm a little adamant to push work on users by introducing a v2, when neither the interface nor the action's code has changed.

Considering Node's track record of backward compatibility, I don't see why we couldn't write Node 12-compatible code and let people's actions happily chug along without changes. Of course if the runner itself lacks fallback logic to use whatever Node version available on the host (wasn't obvious at first glance), it could cause breakages for customers running outdated self-hosted runners, in which case a v2 would seem (unfortunately) a reasonable choice.

[hoffa]

@chenrui333 We've released setup-sam@v2, thanks for the contribution!

(For posterity, I asked for guidance in actions/runner#1824 regarding the major version update)