feat(geo): add Maps API #1452
Merged
feat(geo): add Maps API #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjuliano
reviewed
Aug 19, 2021
aws-geo-location/src/main/java/com/amplifyframework/geo/location/AWSLocationGeoPlugin.kt
Outdated
Show resolved
Hide resolved
rjuliano
reviewed
Aug 19, 2021
| onError: Consumer<GeoException> | ||
| ) { | ||
| try { | ||
| onResult.accept(pluginConfiguration.maps!!.items) |
There was a problem hiding this comment.
Can pluginConfiguration.maps be null?
You may be able to do something like:
pluginConfiguration.maps?.let { onResult.accept(it.items) }There was a problem hiding this comment.
Yep! I imagine some people may choose not to use the maps API in Geo and not configure it to begin with.
In such case, maps configuration will be null, and the NPE will be caught to trigger an error callback.
There was a problem hiding this comment.
Using let will simply return null rather than triggering an error as it should, which is why I simply used !! instead.
rjuliano
reviewed
Aug 19, 2021
| onError: Consumer<GeoException> | ||
| ) { | ||
| try { | ||
| onResult.accept(pluginConfiguration.maps!!.default) |
rjuliano
approved these changes
Aug 19, 2021
raphkim
added a commit
that referenced
this pull request
Sep 21, 2021
* feat(geo): adds Geo category to Amplify (#1450) * feat(geo): adds implementation of Geo category plugin (#1451) * feat(geo): add Maps API (#1452) * feat(geo): add MapLibre adapter for Geo plugin (#1456) * feat(core): register geo category to Amplify and Hub (#1474) * feat(geo): add getMapStyleDescriptor API to Geo (#1475) * chore(geo): fix checkstyle errors * feat(geo): add convenience method for setting map style (#1497) * chore(geo): add alpha version to geo (#1499) * fix(geo): Add JvmStatic to static methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getAvailableMaps()getDefaultMap()Dependent on #1451
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.