Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): add MapLibre adapter for Geo plugin #1456

Merged
merged 2 commits into from Aug 31, 2021
Merged

feat(geo): add MapLibre adapter for Geo plugin #1456

merged 2 commits into from Aug 31, 2021

Conversation

raphkim
Copy link
Contributor

@raphkim raphkim commented Aug 19, 2021

Description of changes:
Implemented MapLibreAdapter#getInstance(Context) to initialize MapLibre SDK and configure with sigV4 signer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@raphkim raphkim requested a review from a team August 19, 2021 16:45
Copy link
Contributor

@rjuliano rjuliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good. I'm just not sure about the name. Would it make sense to add some sort of Amplify prefix to the module name?

@raphkim raphkim requested a review from rjuliano August 30, 2021 23:30
Copy link
Contributor

@rjuliano rjuliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@raphkim raphkim merged commit 6ba4718 into geo Aug 31, 2021
@raphkim raphkim deleted the geo-maplibre branch August 31, 2021 19:53
raphkim added a commit that referenced this pull request Sep 21, 2021
* feat(geo): adds Geo category to Amplify (#1450)

* feat(geo): adds implementation of Geo category plugin (#1451)

* feat(geo): add Maps API (#1452)

* feat(geo): add MapLibre adapter for Geo plugin (#1456)

* feat(core): register geo category to Amplify and Hub (#1474)

* feat(geo): add getMapStyleDescriptor API to Geo (#1475)

* chore(geo): fix checkstyle errors

* feat(geo): add convenience method for setting map style (#1497)

* chore(geo): add alpha version to geo (#1499)

* fix(geo): Add JvmStatic to static methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants