fix(api): When a mutation response code indicates client error only call onFailure #2255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a mutation response code indicates a client error (i.e. code >= 400 && code <= 499), both the
onFailure
andonResponse
callbacks are called.This is problematic when the
mutate
call is wrapped in a Kotlin coroutine (i.e. like the Kotlin facade), because the continuation resumes with exception whenonFailure
is called and will throw an exception when attempting to resume without exception.This PR returns immediately after calling
onFailure
to avoid calling both callbacks. It also adds a test to ensure both callbacks are not called.How did you test these changes?
Added unit test
Documentation update required?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.