Get LIST operations working RDS #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for timestamp fields in mysql, map correctly to AWSDateTime in AppSync
sundersc
approved these changes
Feb 9, 2023
sundersc
reviewed
Feb 9, 2023
| const query = (await this.getClient())(request.table).select().offset(nextOffset).limit(limit); | ||
|
|
||
| this.addSortConditions(query, request); | ||
| const result = await query.returning('*'); |
There was a problem hiding this comment.
Is returning supported in MySQL? I remember getting an error with mutation queries.
sundersc
approved these changes
Feb 9, 2023
AaronZyLee
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for timestamp fields in mysql, map correctly to AWSDateTime in AppSync
Description of changes
Fixes issues with the input signature matching when calling list on lambda
Also updates field mapping for generating schema from RDS so MySQL timestamp is correctly mapped to AWSDateTime scalar type
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.