Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding relational snapshot tests for non-id primary keys #1307

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

alharris-at
Copy link
Contributor

Description of changes

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at requested a review from a team as a code owner February 27, 2023 22:34
@codecov-commenter
Copy link

Codecov Report

Merging #1307 (9b886fc) into main (63da24a) will increase coverage by 0.08%.
The diff coverage is 88.40%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1307      +/-   ##
==========================================
+ Coverage   63.56%   63.64%   +0.08%     
==========================================
  Files         295      297       +2     
  Lines       18573    18616      +43     
  Branches     4487     4487              
==========================================
+ Hits        11805    11848      +43     
+ Misses       6150     6148       -2     
- Partials      618      620       +2     
Impacted Files Coverage Δ
...graphql-transformer/transform-graphql-schema-v1.ts 8.96% <ø> (ø)
...graphql-transformer/transform-graphql-schema-v2.ts 19.41% <0.00%> (ø)
.../src/graphql-transformer/transformer-options-v2.ts 14.76% <ø> (ø)
...ry-api/src/provider-utils/supported-datasources.ts 100.00% <ø> (ø)
...-schema-validator/src/helpers/is-scalar-or-enum.ts 100.00% <ø> (ø)
...rc/validators/relation-required-with-belongs-to.ts 95.23% <ø> (-0.22%) ⬇️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
.../amplify-util-mock/src/api/lambda-arn-to-config.ts 100.00% <ø> (ø)
packages/amplify-util-mock/src/mockAll.ts 0.00% <ø> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alharris-at alharris-at merged commit 94332b9 into main Feb 28, 2023
@alharris-at alharris-at deleted the update-snapshots-for-relational branch February 28, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants