chore: adding depcheck step to post-commit hook #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
force-pushed
the
add-dependency-cruiser
branch
from
0ae94b9
to
726c4c7
Compare
dpilch
requested changes
May 31, 2023
alharris-at
force-pushed
the
add-dependency-cruiser
branch
from
726c4c7
to
3259889
Compare
phani-srikar
approved these changes
May 31, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1523 +/- ##
=======================================
Coverage 62.35% 62.35%
=======================================
Files 361 361
Lines 21522 21522
Branches 5116 5116
=======================================
Hits 13419 13419
Misses 7354 7354
Partials 749 749 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpilch
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding depcheck step to post-commit hook. This is intended to validate we don't reintroduce key dependencies into the GQLV2 dependency chain. There are other ways to do this, but this was just something we can add ASAP while we're touching the deps.
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Test-committed file w/
fsas an import.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.