Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve DX for SSHing to debug failed E2E #1744

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Jul 31, 2023

Description of changes

Passing the debug e2e workflow that is auto-generated as an inline buildspec file to the codebuild trigger call.
This will eliminate the need to commit that file to the repository and save us some steps.
The breakpoints added in the PR do not block the normal E2E runs unless run using yarn cloud-e2e-debug.

Usage:

  • yarn cloud-e2e-debug <batch-build-id> will generate a debug e2e spec file which is not versioned and will trigger an E2E workflow with debug mode ON for failing tests that you can directly SSH into.

  • If you want to make changes to the codebuild-breakpoint locations or add new ones, you can edit the debug_workflow.yml file and re-trigger the workflow using yarn cloud-e2e-debug --use-existing-debug-spec which will keep your changes.

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

Testing with recent batch failure

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested review from a team as code owners July 31, 2023 23:25
@phani-srikar phani-srikar marked this pull request as draft July 31, 2023 23:25
@phani-srikar phani-srikar marked this pull request as ready for review July 31, 2023 23:57
@phani-srikar phani-srikar merged commit db6c645 into main Aug 3, 2023
6 of 7 checks passed
@phani-srikar phani-srikar deleted the improve-ssh-dx branch August 3, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants