Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump deps on data packages, and update tests which reach within the transformer interface #13094

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Aug 8, 2023

Description of changes

  • Bump to next major version of amplify transformer dependencies.
  • Update mock utility tests to shim a synth in order to test the underlying transformers (this is a dupe of changes made in API category).
  • Remove graphql-migration-tests since the v1->v2 transformer behavior should be fully tested within the API category, and re-testing here is not a frugal use of resources. The reason we left e2e tests in both repos was to ensure that interactions across categories would be tested, but these tests validate strictly the behavior of the transformer.
  • Remove unused dep on transformer core from cloudformation provider package.

This PR pulls in the following releases:

Which consists of the following changes:

Issue #, if available

N/A

Description of how you validated changes

Unit + E2E tests https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22801/workflows/ec9ea148-08d9-4982-a6bb-0896540402aa

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at force-pushed the update-gql-e2e-tests-for-api-update branch 2 times, most recently from 1e0b800 to d4997ff Compare August 9, 2023 18:54
@alharris-at alharris-at marked this pull request as ready for review August 9, 2023 18:55
@alharris-at alharris-at requested a review from a team as a code owner August 9, 2023 18:55
AaronZyLee
AaronZyLee previously approved these changes Aug 9, 2023
sundersc
sundersc previously approved these changes Aug 9, 2023
@alharris-at alharris-at dismissed stale reviews from sundersc and AaronZyLee via ea1f3c0 August 10, 2023 04:25
@alharris-at alharris-at force-pushed the update-gql-e2e-tests-for-api-update branch from d4997ff to ea1f3c0 Compare August 10, 2023 04:25
sundersc
sundersc previously approved these changes Aug 10, 2023
AaronZyLee
AaronZyLee previously approved these changes Aug 10, 2023
sundersc
sundersc previously approved these changes Aug 10, 2023
dpilch
dpilch previously approved these changes Aug 10, 2023
awsluja
awsluja previously approved these changes Aug 11, 2023
@alharris-at alharris-at dismissed stale reviews from awsluja, dpilch, and sundersc via cf8695a August 28, 2023 23:40
@alharris-at alharris-at force-pushed the update-gql-e2e-tests-for-api-update branch from dca1353 to cf8695a Compare August 28, 2023 23:40
@alharris-at alharris-at force-pushed the update-gql-e2e-tests-for-api-update branch from cf8695a to ac69e47 Compare August 28, 2023 23:45
@alharris-at alharris-at changed the title chore: bump deps on data packages, and update tests which reach within the transformer interface feat: bump deps on data packages, and update tests which reach within the transformer interface Aug 29, 2023
Copy link
Contributor

@awsluja awsluja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -26,7 +24,7 @@ export class ApiCategoryFacade {
* Perform the actual transformation for a given project. This is predominantlyu a side-effecting call, but we
* also return the deployment resources as well.
*/
static async transformGraphQLSchema(context: $TSContext, options: $TSAny): Promise<DeploymentResources | undefined> {
static async transformGraphQLSchema(context: $TSContext, options: $TSAny): Promise<$TSAny | undefined> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type is no longer exported from our core packages, and this type isn't actually used anywhere in the system. I could import the type directly, but instead elected to just leave this as an any which was the state before we added these facades.

@sobolk sobolk merged commit d374fee into dev Aug 29, 2023
6 checks passed
@sobolk sobolk deleted the update-gql-e2e-tests-for-api-update branch August 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants