-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump deps on data packages, and update tests which reach within the transformer interface #13094
Conversation
packages/amplify-util-mock/src/__e2e_v2__/test-synthesizer/stack-synthesizer.ts
Dismissed
Show dismissed
Hide dismissed
1e0b800
to
d4997ff
Compare
d4997ff
to
ea1f3c0
Compare
ea1f3c0
to
0f49d25
Compare
0f49d25
to
dca1353
Compare
cf8695a
dca1353
to
cf8695a
Compare
…n the transformer interface
cf8695a
to
ac69e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -26,7 +24,7 @@ export class ApiCategoryFacade { | |||
* Perform the actual transformation for a given project. This is predominantlyu a side-effecting call, but we | |||
* also return the deployment resources as well. | |||
*/ | |||
static async transformGraphQLSchema(context: $TSContext, options: $TSAny): Promise<DeploymentResources | undefined> { | |||
static async transformGraphQLSchema(context: $TSContext, options: $TSAny): Promise<$TSAny | undefined> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type is no longer exported from our core packages, and this type isn't actually used anywhere in the system. I could import the type directly, but instead elected to just leave this as an any
which was the state before we added these facades.
Description of changes
This PR pulls in the following releases:
Which consists of the following changes:
Issue #, if available
N/A
Description of how you validated changes
Unit + E2E tests https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/22801/workflows/ec9ea148-08d9-4982-a6bb-0896540402aa
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.