test(api): restrict e2e rds instances public access #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundersc
changed the title
sundersc
force-pushed
the
fix-e2e-public-access
branch
from
7d883bc
to
4898660
Compare
palpatim
reviewed
Sep 22, 2023
Addressed it. Moved the complete database setup and port opening logic to the E2E core. |
phani-srikar
approved these changes
Sep 25, 2023
palpatim
reviewed
Sep 25, 2023
|
|
||
| export const getIpRanges = async (): Promise<string[]> => { | ||
| return Promise.all( | ||
| [IPIFY_URL, AWSCHECKIP_URL].map(async (url) => { |
There was a problem hiding this comment.
On my workstation, I get the same result from both services. We should dedupe the result set so we don't create multiple rules with the same IP ranges.
There was a problem hiding this comment.
Are you connected to VPN? If yes, then the IPs would differ. We can't create a duplicate rule. If there is already an entry, the second API call would fail and we ignore the error.
palpatim
approved these changes
Sep 25, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Restrict inbound security role added by E2E tests to smaller CIDR range (example: x.y.0.0/16). Also, now the ports are open for a very short time to execute the initial DDLs to create tables. The total time the port kept open has decreased from an average of 15 minutes to less than 5 seconds.
Improve SSM read parameter timeout issue. Instead of throwing an exception from wait method, now it returns a string which is used to determine whether to throw an error or not. (This avoids incorrect logging of exception message in the cloudwatch logs).
CDK / CloudFormation Parameters Changed
NA
Issue #, if available
NA
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.