chore: add ap-east-1 (HKG) region #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petercwk-aws
commented
Oct 13, 2023
| @@ -30,6 +30,7 @@ const serviceRegionMap = { | |||
| 'us-west-2': 'us-west-2', | |||
| 'cn-north-1': 'us-west-2', | |||
| 'cn-northwest-1': 'us-west-2', | |||
| 'ap-east-1': 'ap-northeast-2', | |||
There was a problem hiding this comment.
Pinpoint is not available in ap-east-1, so falling back to ap-northeast-2
2 tasks
AaronZyLee
approved these changes
Oct 23, 2023
dpilch
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR enables support in ap-east-1 region (HKG). Associated with aws-amplify/amplify-cli#13332
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
I set
ap-east-1in my ~/.aws/config for my amplify profile and created an app.I ran:
amplify-dev init
amplify-dev add api (default graphQL options)
amplify-dev push
I was able to observe the stack successfully deployed to HKG.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.