test(api): e2e for iam provider on rds models #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundersc
commented
Oct 16, 2023
Comment on lines
+112
to
+121
| blogIAMUnauthClient = constructBlogHelper(unauthAppSyncClient); | ||
| postIAMUnauthClient = constructPostHelper(unauthAppSyncClient); | ||
| userIAMUnauthClient = constructUserHelper(unauthAppSyncClient); | ||
| profileIAMUnauthClient = constructProfileHelper(unauthAppSyncClient); | ||
| blogIAMAuthClient = constructBlogHelper(authAppSyncClient); | ||
| postIAMAuthClient = constructPostHelper(authAppSyncClient); | ||
| userIAMAuthClient = constructUserHelper(authAppSyncClient); | ||
| profileIAMAuthClient = constructProfileHelper(authAppSyncClient); | ||
| userApiKeyClient = constructUserHelper(apiKeyClient); | ||
| userLambdaClient = constructUserHelper(lambdaClient); |
There was a problem hiding this comment.
Some of these clients are unused today but left them here for future work to add more test cases.
alharris-at
reviewed
Oct 16, 2023
| cognitoIdentityPoolId: hasIdentityPoolId ? ref('ctx.stash.identityPoolId') : nul(), | ||
| ...(role.strategy === 'private' && { cognitoIdentityPoolId: identityPoolId ? str(identityPoolId) : nul() }), |
There was a problem hiding this comment.
You need to reference the identityPoolId in stash, right? I don't think that value identityPoolId you're referencing exists. This should fail to build if I'm not mistaken.
There was a problem hiding this comment.
Yeah, just double-checked, and it looks like the build is failing on this.
There was a problem hiding this comment.
Ah, looks rebase didn't go well. Looking into it.
There was a problem hiding this comment.
PR has been updated now with the correct changes.
alharris-at
previously approved these changes
Oct 16, 2023
|
The build job is still failing |
|
All the tests are passing now. |
alharris-at
approved these changes
Oct 17, 2023
phani-srikar
approved these changes
Oct 17, 2023
sundersc
merged commit 4845915
into
aws-amplify:feature/rds-support-preview2
4 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding E2E tests for Auth Directive IAM provider support.