Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable allowListedRoles as string #2016

Merged
merged 2 commits into from
Nov 3, 2023
Merged

feat: enable allowListedRoles as string #2016

merged 2 commits into from
Nov 3, 2023

Conversation

alharris-at
Copy link
Contributor

@alharris-at alharris-at commented Nov 3, 2023 •
edited
Loading

Description of changes

  • Mark adminRoles as deprecated, and point users to allowListedRoles.
  • Add allowListedRoles to iamConfig for auth as a list of IRole or string.
  • Add a few tests.
CDK / CloudFormation Parameters Changed

Yes, allow strings for adminRole in addition to IRole.

Issue #, if available

N/A

Description of how you validated changes

Unit + Functional tests.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alharris-at alharris-at requested a review from a team as a code owner November 3, 2023 19:11
@alharris-at alharris-at requested a review from a team as a code owner November 3, 2023 19:35
@alharris-at alharris-at merged commit 02b9cc0 into main Nov 3, 2023
6 checks passed
@alharris-at alharris-at deleted the admin-role-as-string branch November 3, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronZyLee AaronZyLee AaronZyLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alharris-at @AaronZyLee