Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Simplify model DataSource definition shapes #2054

Merged
merged 2 commits into from
Nov 10, 2023
Merged

feat!: Simplify model DataSource definition shapes #2054

merged 2 commits into from
Nov 10, 2023

Conversation

palpatim
Copy link
Member

Description of changes

API changes to simplify customer declarations of a GraphqlApiDefinition:

Old Name New Name
ModelDataSourceDefinition.name Moved into the SQL-related strategy
ModelDataSourceDefinition Deleted
ModelDataSourceDefinitionStrategy ModelDataSourceStrategy
AmplifyDynamoDbModelDataSourceDefinitionStrategy AmplifyDynamoDbModelDataSourceStrategy
DefaultDynamoDbModelDataSourceDefinitionStrategy DefaultDynamoDbModelDataSourceStrategy
AmplifyGraphqlApiDefinition.fromFilesAndDefinition AmplifyGraphqlApiDefinition.fromFilesAndStrategy
SQLLambdaModelDataSourceDefinitionStrategy SQLLambdaModelDataSourceStrategy
IAmplifyGraphqlDefinition.dataSourceDefinition IAmplifyGraphqlDefinition.dataSourceStrategies
ModelDataSourceDefinitionDbType ModelDataSourceStrategyDbType
  • Appropriate named argument changes to reflect above
  • Appropriate test changes to reflect above

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

palpatim
palpatim commented Nov 10, 2023
View reviewed changes
Copy link
Member Author

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marker review

@palpatim palpatim marked this pull request as ready for review November 10, 2023 21:19
@palpatim palpatim requested review from a team as code owners November 10, 2023 21:19
@palpatim palpatim enabled auto-merge (squash) November 10, 2023 21:19
AaronZyLee
AaronZyLee previously approved these changes Nov 10, 2023
View reviewed changes
alharris-at
alharris-at approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@alharris-at alharris-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval contingent on updating the item's Phani's asking about, but the API updates look good to me.

@palpatim palpatim merged commit a02ca1f into main Nov 10, 2023
6 checks passed
@palpatim palpatim deleted the palpatim.feat.simplify-model-shapes branch November 10, 2023 22:38
@alharris-at alharris-at mentioned this pull request Nov 15, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phani-srikar phani-srikar phani-srikar approved these changes

@alharris-at alharris-at alharris-at approved these changes

@AaronZyLee AaronZyLee AaronZyLee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palpatim @AaronZyLee @phani-srikar @alharris-at