test: test permutations of auth strategies & operations #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
force-pushed
the
palpatim.test.port-v1-auth-operations
branch
from
1ffc1b7
to
748a274
Compare
| transformers, | ||
| resolverConfig, | ||
| dataSourceStrategies: constructDataSourceStrategies(schema, strategy), | ||
| }); |
There was a problem hiding this comment.
sync and search are not supported for SQL datasource strategies. But the fact that the transformation succeeds here probably means we're missing those validations.
There was a problem hiding this comment.
Fixed, thanks for the callout
palpatim
commented
Jan 3, 2024
| rules: AuthRule[], | ||
| configuredAuthProviders: ConfiguredAuthProviders, | ||
| typeName: string, | ||
| context: TransformerSchemaVisitStepContextProvider, |
There was a problem hiding this comment.
I'm a bit uncomfortable plumbing the transformer DataSourceProvider/transformer context through to this level, since we've avoided coupling up until now. But the validation needs to be able to tell if these are SQL strategies, and it's cleaner to centralize validations in a single file rather than spreading them through the transformer code, so this seemed like a compromise I could live with.
phani-srikar
previously approved these changes
Jan 3, 2024
phani-srikar
previously approved these changes
Jan 3, 2024
palpatim
force-pushed
the
palpatim.test.port-v1-auth-operations
branch
from
64d9afc
to
dd59aa3
Compare
6 tasks
phani-srikar
previously approved these changes
Jan 4, 2024
palpatim
force-pushed
the
palpatim.test.port-v1-auth-operations
branch
from
dd59aa3
to
94622e5
Compare
sundersc
approved these changes
Jan 16, 2024
AaronZyLee
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds tests for iterating over single combinations of of auth strategies & operations, to cover some cases I couldn't find elsewhere. Also adds field-level auth rule combination tests. Adds support for generating snapshots as a developer tool for validating changes that impact resolver or stack resource generation.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.