test: improve E2E test reliability #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes deployment errors due to unsupported Node14 Lambda runtime in custom resource provider in CDK v2.80.0
palpatim
changed the title
palpatim
changed the title
atierian
reviewed
Feb 16, 2024
sundersc
reviewed
Feb 16, 2024
| stripColors: true, | ||
| env, | ||
| disableCIDetection: s.disableCIDetection, | ||
| noOutputTimeout: 10 * 60 * 1000, |
There was a problem hiding this comment.
Does init take 10 minutes? Searchable tests may need longer timeouts too.
There was a problem hiding this comment.
Let's keep an eye on that -- I'm not seeing failures in searchable tests, so it may be that I am barking up the wrong tree entirely.
There was a problem hiding this comment.
Searchable tests usually takes longer time during amplify push which was resolved previously. The init process time should stay the same as the others
sundersc
previously approved these changes
Feb 16, 2024
atierian
approved these changes
Feb 16, 2024
6 tasks
AaronZyLee
approved these changes
Feb 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.