-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow subscriptions to inherit primary model auth rules for relational fields behind a feature flag #2649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust doc comments for feature flag and link to published docs explaining the behavior
* When disabled, relational fields on the mutation response are over-redacted to protect the data from subscribed users | ||
* to correctly apply the auth rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest something like:
* When enabled, suppresses default behavior of redacting relational fields when auth rules do not exactly match.
* See <link to doc update>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment. Doc update isn't ready, will update once we have the docs update published.
* When disabled, relational fields on the mutation response are over-redacted to protect the data from subscribed users | ||
* to correctly apply the auth rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest something like:
* When enabled, suppresses default behavior of redacting relational fields when auth rules do not exactly match.
* See <link to doc update>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment. Doc update isn't ready, will update once we have the docs update published.
Description of changes
Allow subscriptions to inherit primary model auth rules for relational fields if
subscriptionsInheritPrimaryAuth
is set totrue
.CDK / CloudFormation Parameters Changed
NA
Issue #, if available
TODO: To be updated later.
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.