feat: allow subscriptions to inherit primary model auth rules for relational fields behind a feature flag #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phani-srikar
previously approved these changes
Jun 21, 2024
palpatim
requested changes
Jun 21, 2024
Comment on lines
431
to
432
| * When disabled, relational fields on the mutation response are over-redacted to protect the data from subscribed users | ||
| * to correctly apply the auth rules. |
There was a problem hiding this comment.
Suggest something like:
* When enabled, suppresses default behavior of redacting relational fields when auth rules do not exactly match.
* See <link to doc update>
There was a problem hiding this comment.
Updated the comment. Doc update isn't ready, will update once we have the docs update published.
Comment on lines
533
to
534
| * When disabled, relational fields on the mutation response are over-redacted to protect the data from subscribed users | ||
| * to correctly apply the auth rules. |
There was a problem hiding this comment.
Suggest something like:
* When enabled, suppresses default behavior of redacting relational fields when auth rules do not exactly match.
* See <link to doc update>
There was a problem hiding this comment.
Updated the comment. Doc update isn't ready, will update once we have the docs update published.
palpatim
approved these changes
Jun 24, 2024
phani-srikar
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Allow subscriptions to inherit primary model auth rules for relational fields if
subscriptionsInheritPrimaryAuthis set totrue.CDK / CloudFormation Parameters Changed
NA
Issue #, if available
TODO: To be updated later.
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.