fix: correct behavior for CreateApiKey config #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the behavior where we look at the old CreateAPIKey flag from transformer v1. We had implemented this in v1 to just look for truthy behavior, which isn't consistent with the previous implementation. Explicitly updating this to only disable for value 0.
Issue #, if available
#80
Description of how you validated changes
Ran in my local CLI to verify the 0/1 behavior a few times, and added unit tests for this behavior to ensure we have consistency in how we're handling these parameters.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.