chore: flip common deps in CLI to peer instead of regular dependencies #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
previously approved these changes
Jun 8, 2022
Comment on lines
109
to
110
| "amplify-util-headless-input": "^1.9.5", | ||
| "amplify-headless-interface": "^1.15.0" |
There was a problem hiding this comment.
amplify-headless-interface should be a dev dep and amplify-util-headless-input should be a peer dep
There was a problem hiding this comment.
Let me test that, when I'd had amplify-util-headless-input as a peer dep previously I'd had some build errors for types not found from that lib, and when adding to both peer and dev dep still wasn't seeing it work.
There was a problem hiding this comment.
I've moved these both to peer deps, and added headless-input to dev-deps as well, since we were failing finding the types withouth.
phani-srikar
previously approved these changes
Jun 8, 2022
alharris-at
dismissed stale reviews from phani-srikar and edwardfoyle
via
1954967
alharris-at
force-pushed
the
use-peer-deps
branch
from
b3936a2
to
1954967
Compare
alharris-at
force-pushed
the
use-peer-deps
branch
from
1954967
to
0f8ad52
Compare
Codecov Report
@@ Coverage Diff @@
## main #520 +/- ##
=======================================
Coverage 62.61% 62.61%
=======================================
Files 276 276
Lines 17723 17723
Branches 4248 4248
=======================================
Hits 11098 11098
Misses 6047 6047
Partials 578 578 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
phani-srikar
approved these changes
Jun 8, 2022
phani-srikar
pushed a commit
that referenced
this pull request
Jun 10, 2022
5 tasks
phani-srikar
pushed a commit
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
flip common deps in CLI to peer instead of regular dependencies
this should protect us from some of the 'Feature Flags is not initialized' type errors we've seen, by ensuring the CLI uses it's own local version of the FeatureFlags lib.
Issue #, if available
N/A
Description of how you validated changes
yarn setup-devand then ran a few test commands w/amplify-dev api gql-compileChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.