Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flip common deps in CLI to peer instead of regular dependencies (#520) #526

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

phani-srikar
Copy link
Contributor

@phani-srikar phani-srikar commented Jun 10, 2022

Description of changes

Moves the dependencies on CLI core and other packages to peer dependencies to avoid problems with initializing FF by having consistent version of CLI core.
Changes already reviewed in #520

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phani-srikar phani-srikar requested a review from a team June 10, 2022 05:44
@phani-srikar phani-srikar changed the base branch from main to release June 10, 2022 05:44
@phani-srikar phani-srikar requested a review from a team June 10, 2022 05:45
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release@892b618). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             release     #526   +/-   ##
==========================================
  Coverage           ?   62.54%           
==========================================
  Files              ?      276           
  Lines              ?    17695           
  Branches           ?     4231           
==========================================
  Hits               ?    11067           
  Misses             ?     6050           
  Partials           ?      578           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@phani-srikar phani-srikar merged commit 0bc7d90 into release Jun 10, 2022
@phani-srikar phani-srikar deleted the release-peer-deps-update branch June 10, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants