Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql): subscription rtf unused filter types cleanup #750

Merged
merged 2 commits into from
Aug 23, 2022

Conversation

sundersc
Copy link
Contributor

Cleanup the type generation added for subscriptions RTF.

@sundersc sundersc requested a review from a team as a code owner August 19, 2022 19:09
@sundersc sundersc changed the title Subscription rtf cleanup chore(graphql): subscription rtf unused filter types cleanup Aug 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #750 (f71bfce) into main (6a7b9f3) will increase coverage by 0.43%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   63.14%   63.58%   +0.43%     
==========================================
  Files         278      279       +1     
  Lines       18125    18212      +87     
  Branches     4375     4401      +26     
==========================================
+ Hits        11445    11580     +135     
+ Misses       6093     6044      -49     
- Partials      587      588       +1     
Impacted Files Coverage Δ
...on-transformer/src/graphql-function-transformer.ts 93.54% <ø> (ø)
...l-http-transformer/src/graphql-http-transformer.ts 96.21% <ø> (ø)
...transformer/src/graphql-predictions-transformer.ts 97.80% <ø> (ø)
...-transformer/src/graphql-belongs-to-transformer.ts 97.26% <ø> (ø)
...al-transformer/src/graphql-has-many-transformer.ts 100.00% <ø> (ø)
...nal-transformer/src/graphql-has-one-transformer.ts 98.59% <ø> (ø)
...searchable-transformer/src/cdk/create-cfnOutput.ts 100.00% <ø> (ø)
...graphql-elasticsearch-transformer/src/resources.ts 100.00% <ø> (ø)
...fy-graphql-auth-transformer/src/resolvers/field.ts 71.42% <33.33%> (+2.04%) ⬆️
...l-transformer-core/src/transformation/transform.ts 16.26% <50.00%> (-0.05%) ⬇️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgtm-com
Copy link

lgtm-com bot commented Aug 19, 2022

This pull request introduces 1 alert when merging a907098 into bbfc243 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@AaronZyLee AaronZyLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit: the unused import can be removed indicated by the bot.

@sundersc sundersc merged commit 986407a into aws-amplify:main Aug 23, 2022
@sundersc sundersc deleted the subscription-rtf-cleanup branch August 23, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants