Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transformer): sort resolvers to avoid circular dependency #797

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix(transformer): sort resolvers to avoid circular dependency #797

merged 1 commit into from
Oct 12, 2022

Conversation

AaronZyLee
Copy link
Contributor

@AaronZyLee AaronZyLee commented Sep 14, 2022 •
edited
Loading

Description of changes

  • Sorted resolvers before synthesis to ensure the resolvers are grouped in stack order.
  • Added e2e tests for mock and push with the GQL schema which previously caused circular dependency problem

Issue #, if available

Fix #560
Fix #554

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AaronZyLee AaronZyLee requested a review from a team as a code owner September 14, 2022 23:52
@AaronZyLee AaronZyLee merged commit e9bf292 into main Oct 12, 2022
@AaronZyLee AaronZyLee deleted the fix-circular-dependency branch October 12, 2022 16:53
@sundersc sundersc mentioned this pull request Feb 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpilch dpilch dpilch approved these changes

@phani-srikar phani-srikar phani-srikar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AaronZyLee @dpilch @phani-srikar