Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): revert circular dependency fix that uses sorting of resolvers #1305

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented Feb 27, 2023

This PR reverts the changes in #797.

Reason: This change potentially introduced circular dependency errors in deployments due to incorrect stack mapping.
#1093
#1156

@sundersc sundersc requested a review from a team as a code owner February 27, 2023 21:40
Copy link
Contributor

@phani-srikar phani-srikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check if this breaks the mock fix to this problem that we released in 10.8.0.

@sundersc sundersc merged commit 2dc5e29 into aws-amplify:main Mar 9, 2023
@phani-srikar phani-srikar changed the title fix(graphql): revert circular dependency mock fix fix(graphql): revert circular dependency fix Mar 13, 2023
@phani-srikar phani-srikar changed the title fix(graphql): revert circular dependency fix fix(graphql): revert circular dependency fix that uses sorting of resolvers Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants