fix(relation-transformer): relation field nullability in object and input type #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
=======================================
Coverage 63.30% 63.31%
=======================================
Files 282 282
Lines 18377 18383 +6
Branches 4461 4466 +5
=======================================
+ Hits 11634 11639 +5
- Misses 6132 6133 +1
Partials 611 611
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alharris-at
reviewed
Sep 29, 2022
AaronZyLee
force-pushed
the
fix-relation-nonnull
branch
from
2c0b0c6
to
24da7fd
Compare
phani-srikar
requested changes
Nov 10, 2022
...-graphql-relational-transformer/src/__tests__/amplify-graphql-belongs-to-transformer.test.ts
Outdated
Show resolved
Hide resolved
...fy-graphql-relational-transformer/src/__tests__/amplify-graphql-has-many-transformer.test.ts
Outdated
Show resolved
Hide resolved
AaronZyLee
commented
Nov 11, 2022
| @@ -262,6 +268,9 @@ export const ensureHasManyConnectionField = ( | |||
| const relatedTypeObject = ctx.output.getType(relatedType.name.value) as ObjectTypeDefinitionNode; | |||
| const connectionAttributeName = getConnectionAttributeName(ctx.featureFlags, object.name.value, field.name.value, connectionFieldName); | |||
|
|
|||
| // The nullabilty of connection fields for hasMany depends on the hasMany field | |||
There was a problem hiding this comment.
I keep this as the original implementation. This is out of the scope of fixing the issue.
phani-srikar
approved these changes
Nov 11, 2022
alharris-at
approved these changes
Nov 15, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactor the impact of non-nullable field with relation directive on the generated connection fields in object definition and input types.
UpdateInputtype, which is consistent to other non-nullable fields.Issue #, if available
Fix aws-amplify/amplify-codegen#461
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.